Add baggage support by siri-varma · Pull Request #1659 · dapr/java-sdk

siri-varma · 2026-02-16T23:21:45Z

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Extended the documentation

Signed-off-by: siri-varma <siri.varma@outlook.com>

siri-varma · 2026-03-02T21:32:51Z

@artur-ciocanu / @cicoyle / @javier-aliaga / @salaboy Please take a look at this PR when you get a chance. Thanks

codecov · 2026-03-04T15:29:38Z

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.54%. Comparing base (a2877aa) to head (6e5bdd9).

Files with missing lines	Patch %	Lines
...rnal/grpc/interceptors/DaprBaggageInterceptor.java	84.61%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1659      +/-   ##
============================================
+ Coverage     79.51%   79.54%   +0.02%     
- Complexity     2194     2196       +2     
============================================
  Files           237      238       +1     
  Lines          6577     6591      +14     
  Branches        730      732       +2     
============================================
+ Hits           5230     5243      +13     
+ Misses          992      990       -2     
- Partials        355      358       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

javier-aliaga · 2026-03-04T16:37:32Z

@siri-varma I ask copilot to review, lets see what it suggest, I will do my own review tomorrow

Copilot

Pull request overview

Adds W3C baggage propagation support to the Dapr Java SDK so that baggage can flow through both gRPC and HTTP calls via Reactor context, and includes a new example + gRPC-focused tests.

Changes:

Add Headers.BAGGAGE constant and propagate it through HTTP header allowlist.
Introduce DaprBaggageInterceptor and wire it into the gRPC interceptor chain.
Add a baggage example and a new gRPC unit test suite validating propagation behavior.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
sdk/src/test/java/io/dapr/client/DaprClientGrpcBaggageTest.java	New gRPC tests validating baggage propagation behavior.
sdk/src/main/java/io/dapr/internal/grpc/interceptors/DaprBaggageInterceptor.java	New gRPC client interceptor injecting `baggage` into metadata from Reactor context.
sdk/src/main/java/io/dapr/internal/grpc/DaprClientGrpcInterceptors.java	Wires the new baggage interceptor into the existing interceptor chain.
sdk/src/main/java/io/dapr/client/Headers.java	Adds a public `BAGGAGE` header constant.
sdk/src/main/java/io/dapr/client/DaprHttp.java	Allows `baggage` to be promoted from Reactor context into outgoing HTTP headers.
examples/src/main/java/io/dapr/examples/baggage/README.md	New documentation for the baggage example.
examples/src/main/java/io/dapr/examples/baggage/BaggageClient.java	New runnable example demonstrating baggage propagation via Reactor context.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-04T16:42:11Z

sdk/src/test/java/io/dapr/client/DaprClientGrpcBaggageTest.java

+  @AfterEach
+  public void tearDown() {
+  }


This @AfterEach method is empty, so it adds noise without providing cleanup. Consider removing it or using it to clean up resources created in setupServer (for example, shutting down the ManagedChannel if not handled by GrpcCleanupRule).

Copilot · 2026-03-04T16:42:11Z

sdk/src/test/java/io/dapr/client/DaprClientGrpcBaggageTest.java

+    Mono<Void> result = invoke()
+        .contextWrite(it -> it.putAll((ContextView) context));
+    result.block();


The cast to ContextView is unnecessary here since Reactor's Context already implements ContextView. Using putAll(context) directly avoids the cast and matches existing patterns in other tests.

Copilot · 2026-03-04T16:42:12Z

sdk/src/test/java/io/dapr/client/DaprClientGrpcBaggageTest.java

+    Mono<Void> result = invoke()
+        .contextWrite(it -> it.putAll((ContextView) context));
+    result.block();


The cast to ContextView is unnecessary here since Reactor's Context already implements ContextView. Using putAll(context) directly avoids the cast and matches existing patterns in other tests.

Copilot · 2026-03-04T16:42:12Z

sdk/src/test/java/io/dapr/client/DaprClientGrpcBaggageTest.java

+    Mono<Void> result = invoke()
+        .contextWrite(it -> it.putAll((ContextView) context));
+    result.block();


The cast to ContextView is unnecessary here since Reactor's Context already implements ContextView. Using putAll(context) directly avoids the cast and matches existing patterns in other tests.

Copilot · 2026-03-04T16:42:12Z

sdk/src/test/java/io/dapr/client/DaprClientGrpcBaggageTest.java

+    Mono<Void> result = invoke()
+        .contextWrite(it -> it.putAll((ContextView) context));
+    result.block();


The cast to ContextView is unnecessary here since Reactor's Context already implements ContextView. Using putAll(context) directly avoids the cast and matches existing patterns in other tests.

Copilot · 2026-03-04T16:42:12Z

sdk/src/main/java/io/dapr/client/DaprHttp.java

+  private static final Set<String> ALLOWED_CONTEXT_IN_HEADERS =
+      Set.of("grpc-trace-bin", "traceparent", "tracestate", "baggage");


This adds baggage to the context-to-header allowlist, but there isn't a corresponding HTTP test asserting the header is actually propagated. Consider extending the existing invokeServiceWithContext test (or adding a new one) to put Headers.BAGGAGE in the Reactor context and assert the outgoing HttpRequest contains the baggage header.

Copilot · 2026-03-04T16:42:13Z

examples/src/main/java/io/dapr/examples/baggage/BaggageClient.java

+import io.dapr.client.DaprClientBuilder;
+import io.dapr.client.Headers;
+import io.dapr.client.domain.HttpExtension;
+import io.dapr.utils.TypeRef;


Unused import io.dapr.utils.TypeRef is present but not referenced in this example. Please remove it to keep the example compiling cleanly under stricter build/lint configurations.

Suggested change

import io.dapr.utils.TypeRef;

Copilot · 2026-03-04T16:42:13Z

sdk/src/test/java/io/dapr/client/DaprClientGrpcBaggageTest.java

+        .addService(service)
+        .build().start());
+
+    ManagedChannel channel = InProcessChannelBuilder.forName(serverName).directExecutor().build();


ManagedChannel created for the in-process server isn't registered with GrpcCleanupRule (and isn't otherwise shut down). This can leak threads/resources across tests; register the channel with grpcCleanup or explicitly shutdown it in an @AfterEach hook.

Suggested change

ManagedChannel channel = InProcessChannelBuilder.forName(serverName).directExecutor().build();

ManagedChannel channel = grpcCleanup.register(

InProcessChannelBuilder.forName(serverName).directExecutor().build());

siri-varma · 2026-03-06T00:33:30Z

@copilot can you fix the comments ?

siri-varma added 4 commits February 16, 2026 15:22

Add baggage

5973074

Signed-off-by: siri-varma <siri.varma@outlook.com>

Merge branch 'master' into users/svegiraju/add-baggage

17d6584

Merge branch 'master' into users/svegiraju/add-baggage

2403e57

Merge branch 'master' into users/svegiraju/add-baggage

4f434d1

siri-varma added the auto-merge label Feb 20, 2026

siri-varma self-assigned this Feb 20, 2026

siri-varma added 5 commits February 21, 2026 17:55

Merge branch 'master' into users/svegiraju/add-baggage

f4a2452

Merge branch 'master' into users/svegiraju/add-baggage

25ae330

Merge branch 'master' into users/svegiraju/add-baggage

cf8ed70

Merge branch 'master' into users/svegiraju/add-baggage

33686be

Merge branch 'master' into users/svegiraju/add-baggage

b743a39

siri-varma marked this pull request as ready for review February 28, 2026 21:43

siri-varma requested review from a team as code owners February 28, 2026 21:43

siri-varma added 2 commits March 1, 2026 21:59

Merge branch 'master' into users/svegiraju/add-baggage

e49d03f

Merge branch 'master' into users/svegiraju/add-baggage

f24ec5f

Merge branch 'master' into users/svegiraju/add-baggage

6e5bdd9

javier-aliaga requested a review from Copilot March 4, 2026 16:37

Copilot started reviewing on behalf of javier-aliaga March 4, 2026 16:37 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

		private static final Set<String> ALLOWED_CONTEXT_IN_HEADERS =
		Set.of("grpc-trace-bin", "traceparent", "tracestate", "baggage");

	ManagedChannel channel = InProcessChannelBuilder.forName(serverName).directExecutor().build();
	ManagedChannel channel = grpcCleanup.register(
	InProcessChannelBuilder.forName(serverName).directExecutor().build());

Conversation

siri-varma commented Feb 16, 2026

Description

Issue reference

Checklist

Uh oh!

siri-varma commented Mar 2, 2026

Uh oh!

codecov bot commented Mar 4, 2026

Codecov Report

Uh oh!

javier-aliaga commented Mar 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

siri-varma commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants